Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cli] ti test --arch argument not work, fix it #764

Merged
merged 1 commit into from
Apr 13, 2020
Merged

[cli] ti test --arch argument not work, fix it #764

merged 1 commit into from
Apr 13, 2020

Conversation

archibate
Copy link
Collaborator

Related issue = #... (if any)

[Click here for the format server]

@archibate
Copy link
Collaborator Author

Not working because pytest doesn't pass the same taichi instance to forked children task now.

@archibate archibate requested a review from yuanming-hu April 13, 2020 01:26
yuanming-hu
yuanming-hu approved these changes Apr 13, 2020
View reviewed changes
Copy link
Member

@yuanming-hu yuanming-hu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! If I understand correcetly, you are assuming all the child process forked by pytest will inherit the TI_WANTED_ARCHS envvar?

@archibate
Copy link
Collaborator Author

Cool! If I understand correcetly, you are assuming all the child process forked by pytest will inherit the TI_WANTED_ARCHS envvar?

Yes, I believe.

@yuanming-hu yuanming-hu merged commit fbc12ab into taichi-dev:master Apr 13, 2020
@yuanming-hu yuanming-hu mentioned this pull request Apr 13, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuanming-hu yuanming-hu yuanming-hu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@archibate @yuanming-hu